Skip to content

Add headless service for distributor #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Add headless service for distributor #148

merged 3 commits into from
Jun 4, 2021

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented May 5, 2021

Create headless service for distributor to allow GRPC load balancing when using HTTP over GRPC for communicating with distributor.

Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However It might be a good idea to have an option to disable the distributor headless service so the user doesn't get confused

Edit: I just noticed thats not what we did apparently with the query_frontend services, so might not be that important

nschad added 2 commits June 3, 2021 21:44
added PR number to changelog

Signed-off-by: ShuzZzle <[email protected]>
@nschad nschad merged commit 3c10ce9 into cortexproject:master Jun 4, 2021
@nschad nschad mentioned this pull request Jun 8, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants