fix #168 #169
fix #168 #169
Conversation
| name: http-metrics | ||
| targetPort: http-metrics | ||
| name: grpc | ||
| targetPort: grpc |
There was a problem hiding this comment.
there is a new ClusterIP Service which only does http-metrics, so basically I moved the http-metrics port to a new service
There was a problem hiding this comment.
ok but the distributors were using the http port to connect to ingesters, with this they will use the grpc port, will it work without other changes?
There was a problem hiding this comment.
@AndreZiviani where do you got that information? Communication between component is almost always (unless mistaken) exclusively grpc
There was a problem hiding this comment.
Besides the Chart's included memberlist Service automatically selects every cortex component with the following label
app.kubernetes.io/part-of: memberlist and then the communication should appear through the 7946 port for memberlist which is exposed by the pods
There was a problem hiding this comment.
I thought the distributor used the ingester headless service to communicate with the ingesters but a quick tcpdump showed traffic on the grpc port, sorry for the confusion
There was a problem hiding this comment.
But why don't you try it out and tell me if its working for you :)
There was a problem hiding this comment.
Applied here and everything is still working 😄
…erIP service with http-metrics port to every component who before only had an headless service before Signed-off-by: ShuzZzle <[email protected]>
Signed-off-by: ShuzZzle <[email protected]>
Signed-off-by: ShuzZzle <[email protected]>
Signed-off-by: ShuzZzle <[email protected]>
What this PR does:
removed http-metrics port from every headless service and added ClusterIP service with http-metrics port to every component who before only had an headless service before. Headless services should not be used for anything http related, therefore I think its fine to completely remove that port from the Service.
No more dupe :) because of 2 Service with the same port
Which issue(s) this PR fixes:
Fixes #168
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]