add lifecycle to querier, distributor, query-frontend #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2021 03:28
Signed-off-by: brian <[email protected]>
Signed-off-by: brian <[email protected]>
|
Hi, Is there a reason you created a new PR instead of updating your old one? #245 ? |
nschad
approved these changes
Nov 18, 2021
|
Yes, because I could not use my other account for the dco due to not receiving approval to do so yet....wanted to get it done on my personal time |
kd7lxl
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: brian [email protected]
What this PR does: Adds in lifecycle as an option for querier, querier-frontend, and distributor
Which issue(s) this PR fixes:
Fixes #243
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]