Adding dnsResolver option to nginx.config #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Layfield <[email protected]>
khaines
approved these changes
May 27, 2020
|
@DandyDeveloper, can you rebase with master for the latest changes from #25? if this PR is still needed post that rebase, I'll merge it in |
…nto improvement/dandydeveloper/allow-different-dns-resolver
|
@khaines All done. I think it's still worth having, as in our case we use kube-proxy, and by default, this chart would only manage kube-dns based CNI |
Skaronator
pushed a commit
to Skaronator/cortex-helm-chart
that referenced
this pull request
Apr 28, 2021
Signed-off-by: Aaron Layfield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Layfield [email protected]
fixes: #27