-
Notifications
You must be signed in to change notification settings - Fork 168
add nginx access log toggle #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nginx access log toggle #402
Conversation
bb36dbe
to
82182b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. However you still need to update CHANGELOG.md with your PR! :)
Also you must sign your commits with DCO!
fb6fab0
to
504cdfd
Compare
I'm not used to contributing, this is my first time. Thanks for your help :) |
Absolutely not a problem. Thank you for your contribution |
62ff3b9
to
0b78700
Compare
0b78700
to
3b52050
Compare
Hey @TuTuRyYE, I shouldn't have pressed the GitHub "update-repo" button. What a mess. Anyway... DCO seems to be stuck. UNLESS YOU HAVE LOCAL CHANGES IN THAT BRANCH
|
Signed-off-by: ajaumet <[email protected]>
Co-authored-by: Niclas Schad <[email protected]> Signed-off-by: ajaumet <[email protected]>
Signed-off-by: ajaumet <[email protected]>
Signed-off-by: ajaumet <[email protected]>
3b52050
to
0a795a9
Compare
What this PR does:
Add a toggle to enable/disable access logs in nginx (similar to loki helm chart)
Which issue(s) this PR fixes:
Nothing
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]