Skip to content

add nginx access log toggle #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TuTuRyYE
Copy link
Contributor

@TuTuRyYE TuTuRyYE commented Oct 5, 2022

What this PR does:
Add a toggle to enable/disable access logs in nginx (similar to loki helm chart)

Which issue(s) this PR fixes:
Nothing

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@TuTuRyYE TuTuRyYE force-pushed the add_logging_verbose_option_to_nginx branch from bb36dbe to 82182b9 Compare October 5, 2022 16:16
Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. However you still need to update CHANGELOG.md with your PR! :)

Also you must sign your commits with DCO!

@TuTuRyYE TuTuRyYE force-pushed the add_logging_verbose_option_to_nginx branch from fb6fab0 to 504cdfd Compare October 6, 2022 12:09
@TuTuRyYE
Copy link
Contributor Author

TuTuRyYE commented Oct 6, 2022

I'm not used to contributing, this is my first time. Thanks for your help :)

@nschad
Copy link
Collaborator

nschad commented Oct 6, 2022

I'm not used to contributing, this is my first time. Thanks for your help :)

Absolutely not a problem. Thank you for your contribution

@TuTuRyYE TuTuRyYE force-pushed the add_logging_verbose_option_to_nginx branch 2 times, most recently from 62ff3b9 to 0b78700 Compare October 12, 2022 09:23
@TuTuRyYE TuTuRyYE requested a review from nschad October 14, 2022 12:59
@nschad nschad requested a review from kd7lxl October 14, 2022 13:31
@nschad nschad force-pushed the add_logging_verbose_option_to_nginx branch 3 times, most recently from 0b78700 to 3b52050 Compare October 17, 2022 07:35
@nschad nschad closed this Oct 17, 2022
@nschad nschad reopened this Oct 17, 2022
@nschad
Copy link
Collaborator

nschad commented Oct 17, 2022

Hey @TuTuRyYE,

I shouldn't have pressed the GitHub "update-repo" button. What a mess. Anyway... DCO seems to be stuck.
Can you do the following on your PC in your cortex-helm-chart repo?

UNLESS YOU HAVE LOCAL CHANGES IN THAT BRANCH

# Assuming origin is your remote name
git fetch origin add_logging_verbose_option_to_nginx
git reset --hard origin/add_logging_verbose_option_to_nginx
# e2de2f1f3dd1ecb95762851cf96c512027b71e8f should be last commit ID from master. Your branch is already rebased. This should clean up any potential weird authors.
git rebase -i e2de2f1f3dd1ecb95762851cf96c512027b71e8f -x "git commit --amend --reset-author -CHEAD"
# push it
git push -u origin add_logging_verbose_option_to_nginx -f

ajaumet and others added 4 commits October 17, 2022 10:07
@TuTuRyYE TuTuRyYE force-pushed the add_logging_verbose_option_to_nginx branch from 3b52050 to 0a795a9 Compare October 17, 2022 08:08
@nschad nschad enabled auto-merge (squash) October 17, 2022 08:11
@nschad nschad merged commit ac382ed into cortexproject:master Oct 17, 2022
@nschad nschad mentioned this pull request Dec 15, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants