Skip to content

cut release 2.6.0 #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

cut release 2.6.0 #541

merged 3 commits into from
May 7, 2025

Conversation

nschad
Copy link
Collaborator

@nschad nschad commented May 6, 2025

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX], [DEPENDENCY]

Signed-off-by: Niclas Schad <[email protected]>
@nschad
Copy link
Collaborator Author

nschad commented May 6, 2025

@kd7lxl Can you check why helm repo index removes the 0.2.0? I can't figure it out

@nschad nschad marked this pull request as draft May 6, 2025 16:26
@kd7lxl
Copy link
Collaborator

kd7lxl commented May 6, 2025

@kd7lxl Can you check why helm repo index removes the 0.2.0? I can't figure it out

No idea. I just tried to reproduce it and wasn't able to. I pushed the index it built for me.

I ran helm repo index docs --url https://cortexproject.github.io/cortex-helm-chart.

Helm version:

% helm version                                                                
version.BuildInfo{Version:"v3.14.4", GitCommit:"81c902a123462fd4052bc5e9aa9c513c4c8fc142", GitTreeState:"clean", GoVersion:"go1.22.2"}

@kd7lxl
Copy link
Collaborator

kd7lxl commented May 6, 2025

Helm version:

% helm version                                                                
version.BuildInfo{Version:"v3.14.4", GitCommit:"81c902a123462fd4052bc5e9aa9c513c4c8fc142", GitTreeState:"clean", GoVersion:"go1.22.2"}

Why is my Helm install a year old? Great question.

Upgrading to v3.17 allows me to reproduce the 0.2.0 removal.

% helm version
version.BuildInfo{Version:"v3.17.3", GitCommit:"e4da49785aa6e6ee2b86efd5dd9e43400318262b", GitTreeState:"clean", GoVersion:"go1.24.2"}
% helm repo index docs --url https://cortexproject.github.io/cortex-helm-chart                   
% git diff
diff --git a/docs/index.yaml b/docs/index.yaml
index c72a218..ebd0d0c 100644
--- a/docs/index.yaml
+++ b/docs/index.yaml
@@ -3,7 +3,7 @@ entries:
   cortex:
   - apiVersion: v2
     appVersion: v1.19.0
-    created: "2025-05-06T09:36:27.460234-07:00"
+    created: "2025-05-06T09:43:08.837704-07:00"
     dependencies:
     - alias: memcached-frontend
       condition: memcached-frontend.enabled
@@ -46,7 +46,7 @@ entries:
     version: 2.6.0
   - apiVersion: v2
     appVersion: v1.18.1
-    created: "2025-05-06T09:36:27.455578-07:00"
+    created: "2025-05-06T09:43:08.83335-07:00"
     dependencies:
     - alias: memcached-frontend
       condition: memcached-frontend.enabled
@@ -89,7 +89,7 @@ entries:
     version: 2.5.0
   - apiVersion: v2
     appVersion: v1.17.1
-    created: "2025-05-06T09:36:27.450829-07:00"
+    created: "2025-05-06T09:43:08.828537-07:00"
     dependencies:
...skipping...
       condition: memcached.enabled
@@ -1185,7 +1185,7 @@ entries:
     version: 0.4.1
   - apiVersion: v2
     appVersion: v1.7.0
-    created: "2025-05-06T09:36:27.375095-07:00"
+    created: "2025-05-06T09:43:08.753023-07:00"
     dependencies:
     - alias: memcached
       condition: memcached.enabled
@@ -1241,7 +1241,7 @@ entries:
     version: 0.4.0
   - apiVersion: v2
     appVersion: v1.6.0
-    created: "2025-05-06T09:36:27.372938-07:00"
+    created: "2025-05-06T09:43:08.749902-07:00"
     dependencies:
     - alias: memcached
       condition: memcached.enabled
@@ -1295,37 +1295,4 @@ entries:
     urls:
     - https://cortexproject.github.io/cortex-helm-chart/cortex-0.3.0.tgz
     version: 0.3.0
-  - apiVersion: v2
-    appVersion: v1.4.0
-    created: "2025-05-06T09:36:27.370452-07:00"
-    dependencies:
-    - alias: memcached
-      condition: memcached.enabled
-      name: memcached
-      repository: https://kubernetes-charts.storage.googleapis.com/
-      version: 3.2.3
-    - alias: memcached-index-read
-      condition: memcached-index-read.enabled
-      name: memcached
-      repository: https://kubernetes-charts.storage.googleapis.com/
-      version: 3.2.3
-    - alias: memcached-index-write
-      condition: memcached-index-write.enabled
-      name: memcached
-      repository: https://kubernetes-charts.storage.googleapis.com/
-      version: 3.2.3
-    description: Cortex
-    digest: f3c06fb19af521cd0daf02e5aaf8236d622df3f372fb8d3237a1103ecc0b810e
-    home: https://cortexmetrics.io/
-    icon: https://avatars2.githubusercontent.com/u/43045022?s=200&v=4
-    kubeVersion: ^1.10.0-0
-    maintainers:
-    - email: [email protected]
-      name: Cortex Maintainers
-    name: cortex
-    sources:
-    - https://github.com/cortexproject/cortex-helm-chart
-    urls:
-    - https://cortexproject.github.io/cortex-helm-chart/cortex-0.2.0.tgz
-    version: 0.2.0
-generated: "2025-05-06T09:36:27.36376-07:00"
+generated: "2025-05-06T09:43:08.745075-07:00"

@kd7lxl
Copy link
Collaborator

kd7lxl commented May 6, 2025

I just tried every release. I could not reproduce it with v3.17.2, but v3.17.3 reproduced it.

% docker run -ti --rm -v $(pwd):/apps -w /apps \
    -v ~/.kube:/root/.kube -v ~/.helm:/root/.helm -v ~/.config/helm:/root/.config/helm \
    -v ~/.cache/helm:/root/.cache/helm \
    alpine/helm:3.17.3 repo index docs --url https://cortexproject.github.io/cortex-helm-chart
% git diff | tail             
-    - email: [email protected]
-      name: Cortex Maintainers
-    name: cortex
-    sources:
-    - https://github.com/cortexproject/cortex-helm-chart
-    urls:
-    - https://cortexproject.github.io/cortex-helm-chart/cortex-0.2.0.tgz
-    version: 0.2.0
-generated: "2025-05-06T09:36:27.36376-07:00"
+generated: "2025-05-06T16:56:57.894075465Z"

The diff between those versions is: helm/helm@v3.17.2...v3.17.3

The change is that it will no longer support uncompressed chart sizes greater than 5MB. cortex-0.2.0.tgz is over that threshold:

% tar zxf docs/cortex-0.2.0.tgz 
% du -hs cortex                
5.5M    cortex

So there's your root cause.

@nschad
Copy link
Collaborator Author

nschad commented May 7, 2025

I just tried every release. I could not reproduce it with v3.17.2, but v3.17.3 reproduced it.

% docker run -ti --rm -v $(pwd):/apps -w /apps \
    -v ~/.kube:/root/.kube -v ~/.helm:/root/.helm -v ~/.config/helm:/root/.config/helm \
    -v ~/.cache/helm:/root/.cache/helm \
    alpine/helm:3.17.3 repo index docs --url https://cortexproject.github.io/cortex-helm-chart
% git diff | tail             
-    - email: [email protected]
-      name: Cortex Maintainers
-    name: cortex
-    sources:
-    - https://github.com/cortexproject/cortex-helm-chart
-    urls:
-    - https://cortexproject.github.io/cortex-helm-chart/cortex-0.2.0.tgz
-    version: 0.2.0
-generated: "2025-05-06T09:36:27.36376-07:00"
+generated: "2025-05-06T16:56:57.894075465Z"

The diff between those versions is: helm/[email protected]

The change is that it will no longer support uncompressed chart sizes greater than 5MB. cortex-0.2.0.tgz is over that threshold:

% tar zxf docs/cortex-0.2.0.tgz 
% du -hs cortex                
5.5M    cortex

So there's your root cause.

Thanks for the deep-dive, haha :D Yeah I have 3.17.3. I guess next-time we can drop 0.2.0

@nschad nschad marked this pull request as ready for review May 7, 2025 06:23
Signed-off-by: Niclas Schad <[email protected]>
@nschad nschad enabled auto-merge (squash) May 7, 2025 06:26
@nschad nschad merged commit f98b14d into master May 7, 2025
2 checks passed
@nschad nschad deleted the cut-2.6.0 branch May 7, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants