make delete request cancellation duration configurable and rename data-purger to purger #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-purger to purger Signed-off-by: Sandeep Sukhani <[email protected]>
Signed-off-by: Sandeep Sukhani <[email protected]>
gouthamve
approved these changes
Jun 22, 2020
Signed-off-by: Sandeep Sukhani <[email protected]>
bboreham
reviewed
Jun 24, 2020
| @@ -50,6 +50,7 @@ | |||
| * [CHANGE] Available command-line flags are printed to stdout, and only when requested via `-help`. Using invalid flag no longer causes printing of all available flags. #2691 | |||
| * [CHANGE] Experimental Memberlist ring: randomize gossip node names to avoid conflicts when running multiple clients on the same host, or reusing host names (eg. pods in statefulset). Node name randomization can be disabled by using `-memberlist.randomize-node-name=false`. #2715 | |||
| * [CHANGE] Memberlist KV client is no longer considered experimental. #2725 | |||
| * [CHANGE] Change target flag for purger from `data-purger` to `purger` and make delete request cancellation duration configurable. #2760 | |||
There was a problem hiding this comment.
Can you clarify where this happened?
Not, for instance, here: https://github.com/cortexproject/cortex/pull/2760/files#diff-596d5408728e4813da55bfbc5a171d3dR63
There was a problem hiding this comment.
Sorry, my bad. I just renamed the components and missed changing the flag. Will open a PR to fix this.
|
Did we mark the purger as experimental? If not, changing the name would trigger a major release. |
Yes, it is marked experimental. See https://github.com/cortexproject/cortex/blob/master/pkg/chunk/purger/purger.go#L141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Duration until which delete requests are allowed to be cancelled after creation is made configurable. This would help with integration tests and run this initially with a higher value until we have more confidence in its stability.
This PR also renames flags and references from datapurger to purger for simplicity and consistency.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]