Disable S3 SSE integration tests #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
treid314
approved these changes
Nov 2, 2021
pstibrany
approved these changes
Nov 2, 2021
bboreham
added a commit
that referenced
this pull request
Nov 3, 2021
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see #4545) Signed-off-by: Bryan Boreham <[email protected]>
1 task
bboreham
pushed a commit
that referenced
this pull request
Nov 3, 2021
Signed-off-by: Marco Pracucci <[email protected]>
bboreham
added a commit
that referenced
this pull request
Nov 4, 2021
…o rc.1 (#4548) * Disable S3 SSE integration tests (#4545) Signed-off-by: Marco Pracucci <[email protected]> * Update go-kit/kit to 0.12.0 to fix spurious debug logs This version of go-kit/kit/log is just a pass-through to go-kit/log. Also updates the following: * github.com/go-kit/log from v0.1.0 to v0.2.0 * github.com/json-iterator/go from v1.1.11 to v1.1.12 * golang.org/x/net from ad29c8ab022f to 978cfadd31cf Pinned aws-sdk to previous version, to reduce the amount of change. Signed-off-by: Bryan Boreham <[email protected]> * compactor unit tests: make log messages consistent Apparently updating go-kit has made our log lines more consistent Signed-off-by: Bryan Boreham <[email protected]> * Bump to rc.1 Signed-off-by: Bryan Boreham <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
alvinlin123
pushed a commit
that referenced
this pull request
Nov 10, 2021
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see #4545) Signed-off-by: Bryan Boreham <[email protected]>
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
Signed-off-by: Marco Pracucci <[email protected]> Signed-off-by: Manish Kumar Gupta <[email protected]>
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see cortexproject#4545) Signed-off-by: Bryan Boreham <[email protected]> Signed-off-by: Manish Kumar Gupta <[email protected]>
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see cortexproject/cortex#4545) Signed-off-by: Bryan Boreham <[email protected]>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Marco Pracucci <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see cortexproject#4545) Signed-off-by: Bryan Boreham <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We have our CI blocked because of #4543. I propose to disable S3 SSE integration tests until we have a better solution (in the meanwhile we shouldn't block all PRs).
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]