Fix memory leak in distributor due to cluster label #4739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
distributor-memory-leak
branch
from
15200a9 to
899cbce
Compare
alanprot
approved these changes
May 12, 2022
|
LGTM |
alvinlin123
reviewed
May 12, 2022
| @@ -19,3 +21,11 @@ func StringsMap(values []string) map[string]bool { | |||
| } | |||
| return out | |||
| } | |||
|
|
|||
| // StringsClone returns a copy input s | |||
| // see: https://github.com/golang/go/blob/master/src/strings/clone.go | |||
There was a problem hiding this comment.
:-) nice! We should update Go one day.
harry671003
force-pushed
the
distributor-memory-leak
branch
from
899cbce to
687f4e4
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
distributor-memory-leak
branch
from
687f4e4 to
c876750
Compare
alvinlin123
approved these changes
May 12, 2022
|
Thanks for this. Note we also have a function with the same intent here: cortex/pkg/ingester/index/index.go Lines 110 to 113 in 4e9fc3a In Go it is fairly common to copy a tiny function rather than exposing it - "a little copying is better than a little dependency". |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The HA cluster label is exposed through the distributor metrics. This can cause memory leak when one tenant sends a lot of different clusters. The metrics is only cleaned up after 30 mins.
The memory is leaked because the
yoloStringin the request is kept alive for a longer period.The following is the memory consumed by the distributor over time without cloning the cluster label.
The following is the memory consumed by distributor when cluster label was cloned.
The above leak in
snappyDecodeappears to have disappeared.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]