Skip to content

Reusing the grpc client to perform health check #6260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

alanprot
Copy link
Member

What this PR does:

Just a small change to avoid creating new connections on every health check call.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot alanprot marked this pull request as ready for review October 10, 2024 23:49
@alanprot alanprot force-pushed the reuse-healthcheck-client branch from 60e6f5d to d974032 Compare October 16, 2024 19:16
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 16, 2024
@alanprot
Copy link
Member Author

@yeya24 PTAL?

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2024
@alanprot alanprot merged commit e455bda into cortexproject:master Oct 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/L type/performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants