Skip to content

Bug fix on JSON Tag #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rajagopalanand
Copy link
Contributor

@rajagopalanand rajagopalanand commented Nov 14, 2024

What this PR does:

Which issue(s) this PR fixes:

The JSON tag for GroupNextToken string `json:"groupNextToken:omitempty" is incorrect. It should be GroupNextToken string `json:"groupNextToken,omitempty"

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. type/bug labels Nov 14, 2024
@rajagopalanand
Copy link
Contributor Author

Will try and add a test

@rajagopalanand rajagopalanand marked this pull request as draft November 14, 2024 17:14
Signed-off-by: Anand Rajagopal <[email protected]>
@rajagopalanand rajagopalanand force-pushed the pagination-json-bug-fix branch from 196fbd9 to 8effb2f Compare November 14, 2024 22:05
@rajagopalanand rajagopalanand marked this pull request as ready for review November 14, 2024 22:06
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@friedrichg friedrichg merged commit 841c296 into cortexproject:master Nov 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. lgtm This PR has been approved by a maintainer size/M type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants