Skip to content

2024.9.x feature notifications #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: 2024.9.x
Choose a base branch
from

Conversation

Fajfa
Copy link
Member

@Fajfa Fajfa commented Mar 24, 2025

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@Fajfa Fajfa requested a review from tjerman March 24, 2025 10:11
Copy link
Member

@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good; need a bit more flexibility in struct defs

@Fajfa Fajfa force-pushed the 2024.9.x-feature-notifications branch 2 times, most recently from 946d23b to 49d930f Compare April 16, 2025 11:29
@Fajfa Fajfa force-pushed the 2024.9.x-feature-notifications branch 4 times, most recently from 90d5b29 to c9d6492 Compare April 23, 2025 08:28
Copy link
Member

@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do

// comment here
line of code := here

instead of

code goes := here // comment here

@Fajfa Fajfa force-pushed the 2024.9.x-feature-notifications branch 2 times, most recently from 0c32bf2 to a5bd4dd Compare April 23, 2025 10:38
@Fajfa Fajfa linked an issue Apr 23, 2025 that may be closed by this pull request
@Fajfa Fajfa force-pushed the 2024.9.x-feature-notifications branch from a5bd4dd to 795af8a Compare April 23, 2025 12:52
@KinyaElGrande KinyaElGrande force-pushed the 2024.9.x-feature-notifications branch from fab6bdd to 3cdcd2f Compare April 25, 2025 12:04
@Fajfa Fajfa force-pushed the 2024.9.x-feature-notifications branch 3 times, most recently from b1b7530 to f4746e0 Compare April 25, 2025 13:08
@Fajfa Fajfa force-pushed the 2024.9.x-feature-notifications branch from f4746e0 to ab0b54f Compare April 25, 2025 13:24
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications feature
2 participants