Skip to content

Fix discovery mappings, indexing and allowed roles #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2024.9.x
Choose a base branch
from
Open

Fix discovery mappings, indexing and allowed roles #2110

wants to merge 4 commits into from

Conversation

KinyaElGrande
Copy link
Contributor

This PR resolves issues in the corteza-discovery flow by :

  1. Fixing the reindexing process to ensure data is actually reindexed on opensearch/elastic search
  2. Adds proper mapping for the security field in indexed compose documents
  3. Adds the super-admin role in the allowed roles list for all the documents.

@KinyaElGrande KinyaElGrande requested a review from tjerman April 22, 2025 10:34
tjerman
tjerman approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@KinyaElGrande KinyaElGrande requested a review from tjerman April 22, 2025 15:32
@Fajfa Fajfa force-pushed the 2024.9.x-fix-discovery-flow branch from bb3f7fd to b87700f Compare April 23, 2025 12:50
@KinyaElGrande KinyaElGrande force-pushed the 2024.9.x-fix-discovery-flow branch from b87700f to 723cfd9 Compare April 25, 2025 08:51
@Fajfa Fajfa force-pushed the 2024.9.x-fix-discovery-flow branch from 723cfd9 to eb9a87c Compare April 25, 2025 13:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Fajfa Fajfa linked an issue Apr 28, 2025 that may be closed by this pull request
Discovery flow check #2106
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjerman tjerman Awaiting requested review from tjerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discovery flow check
2 participants
@KinyaElGrande @tjerman