Change User Supplied Param Change Value to json.RawMessage

[alexanderbez]

The values in changes in Parameter change proposals are now of type json.RawMessage so users no longer have to string-encode them leading to a better UX.

closes #4237

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry: clog add [section] [stanza] [message]

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #4253 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4253      +/-   ##
==========================================
- Coverage   58.91%   58.89%   -0.03%     
==========================================
  Files         215      216       +1     
  Lines       14482    14499      +17     
==========================================
+ Hits         8532     8539       +7     
- Misses       5310     5320      +10     
  Partials      640      640

[alessio]

tACK

It'd be nice to have test cases covering NewParamChangeJSON(),ToParamChange(), and ToParamChanges() to keep up coverage.

I think this is worth a pending entry too.

[alexanderbez]

@alessio it's not worth a pending entry because this feature hasn't been released yet -- ie. the pending log entry would be redundant.

I also added unit tests for the utils.

[fedekunze]

LGTM

[alexanderbez]

Addressed your feedback @alessio

[jackzampolin]

Does this break amino encoding?

[alexanderbez]

No, in this case MaxValidators is a uint16 which isn't string-encoded -- it's just an int.

[vdsprakash]

I have tried of changing the the MaxValidators,SignedBlocksWindow in my own test network. The proposal was passed but the parameter is not changed.

[alexanderbez]

@vdsprakash I would double check your proposal and if the proposal actually passed or not. If it did not pass, did it fail or was it rejected?

I've tested the param change proposal process on Gaia v2.0.2 which we'll use for the next major upgrade and it works just fine. Here is a screen recording where I change the two parameters you've mentioned.

Here is the parameter change proposal content:

{
  "title": "Update MaxValidators and SignedBlocksWindow params",
  "description": "Update MaxValidators and SignedBlocksWindow params",
  "changes": [
    {
      "subspace": "staking",
      "key": "MaxValidators",
      "value": 200
    },
    {
      "subspace": "slashing",
      "key": "SignedBlocksWindow",
      "value": "200"
    }
  ],
  "deposit": [
    {
      "denom": "stake",
      "amount": "10000000"
    }
  ]
}