Skip to content

fix open cover reporter so that it uses unique ids over multiple modules #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/coverlet.core/Reporters/OpenCoverReporter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ public string Format(CoverageResult result)
int numSequencePoints = 0, numClasses = 0, numMethods = 0;
int visitedSequencePoints = 0, visitedClasses = 0, visitedMethods = 0;

int i = 1;

foreach (var mod in result.Modules)
{
XmlElement module = xml.CreateElement("Module");
Expand All @@ -44,10 +46,8 @@ public string Format(CoverageResult result)
module.AppendChild(name);

XmlElement files = xml.CreateElement("Files");
XmlElement classes = xml.CreateElement("Classes");

int i = 1;

XmlElement classes = xml.CreateElement("Classes");

foreach (var doc in mod.Value)
{
XmlElement file = xml.CreateElement("File");
Expand Down
50 changes: 46 additions & 4 deletions test/coverlet.core.tests/Reporters/OpenCoverReporterTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,34 @@ public void TestFormat()
{
CoverageResult result = new CoverageResult();
result.Identifier = Guid.NewGuid().ToString();

result.Modules = new Modules();
result.Modules.Add("Coverlet.Core.Reporters.Tests", CreateFirstDocuments());

OpenCoverReporter reporter = new OpenCoverReporter();
Assert.NotEqual(string.Empty, reporter.Format(result));
}

[Fact]
public void TestFilesHaveUniqueIdsOverMultipleModules()
{
CoverageResult result = new CoverageResult();
result.Identifier = Guid.NewGuid().ToString();

result.Modules = new Modules();
result.Modules.Add("Coverlet.Core.Reporters.Tests", CreateFirstDocuments());
result.Modules.Add("Some.Other.Module", CreateSecondDocuments());

OpenCoverReporter reporter = new OpenCoverReporter();
var xml = reporter.Format(result);
Assert.NotEqual(string.Empty, xml);

Assert.Contains(@"<FileRef uid=""1"" />", xml);
Assert.Contains(@"<FileRef uid=""2"" />", xml);
}

private static Documents CreateFirstDocuments()
{
Lines lines = new Lines();
lines.Add(1, 1);
lines.Add(2, 0);
Expand All @@ -19,11 +47,25 @@ public void TestFormat()
classes.Add("Coverlet.Core.Reporters.Tests.OpenCoverReporterTests", methods);
Documents documents = new Documents();
documents.Add("doc.cs", classes);
result.Modules = new Modules();
result.Modules.Add("module", documents);
return documents;
}

OpenCoverReporter reporter = new OpenCoverReporter();
Assert.NotEqual(string.Empty, reporter.Format(result));
private static Documents CreateSecondDocuments()
{
Lines lines = new Lines();
lines.Add(1, 1);
lines.Add(2, 0);

Methods methods = new Methods();
methods.Add("System.Void Some.Other.Module.TestClass.TestMethod()", lines);

Classes classes2 = new Classes();
classes2.Add("Some.Other.Module.TestClass", methods);

var documents = new Documents();
documents.Add("TestClass.cs", classes2);

return documents;
}
}
}