Update onboarding illustration and wording & fix navigation from cozy-bar in flagship app #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background was half white half gray. Now it is full white as intended.
The new cozy-bar added recently leverages the WebviewIntentProvider to navigate to home and other apps on flagship app. Unfortunately, it is not possible to use multiple WebviewIntentProvider in an app. cozy-intent does not support it. But the cozy-pass-web app is built around multiple React wrapper so we can not have one WebviewIntentProvider for the entire app and we also need it to check if the pass mobile app is installed during the onboarding process. So here we : - move the WebviewIntentProvider from ReactWrapper to the BarWrapper so it is instanciated only once - expose a proxy using JS events to allow other part of the code to call webviewIntent.call - use this proxy to check if the pass mobile app is installed
zatteo
changed the title
BundleMonFiles updated (2)
Total files change -2.47KB -0.08% Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.