Skip to content

debugging: Update linux ssh instructions #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

cfergeau
Copy link
Contributor

@cfergeau cfergeau commented Apr 17, 2025

linux now uses usermode networking by default, so the instructions to
ssh into the VM need to be updated.

Summary by Sourcery

Documentation:

  • Update SSH configuration and connection instructions to clarify IP address and port for different network modes on Linux and macOS

Copy link

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

The pull request updates the SSH configuration and instructions for connecting to the CRC VM via SSH. The changes accommodate the default usermode networking configuration in Linux, which uses a different IP address and port for SSH connections.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the SSH configuration and instructions for connecting to the CRC VM via SSH.
  • Changed the default hostname in the SSH configuration from 192.168.130.11 to 127.0.0.1.
  • Added a port specification (Port 2222) to the SSH configuration.
  • Updated the debugging instructions to reflect the correct IP address and port for user network mode.
  • Clarified the IP address and port for system network mode on Linux.
  • Consolidated the SSH command for Linux and macOS into a single command.
  • Updated the SSH command to use port 2222 and the IP address 127.0.0.1.
content/Debugging.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cfergeau - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It would be good to also update the crc ssh command example if that is affected.
  • Consider mentioning the network mode setting in the documentation for completeness.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

linux now uses usermode networking by default, so the instructions to
ssh into the VM need to be updated.
@gbraad gbraad merged commit 7e55a2f into crc-org:main Apr 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants