-
Notifications
You must be signed in to change notification settings - Fork 5
debugging: Update linux ssh instructions #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe pull request updates the SSH configuration and instructions for connecting to the CRC VM via SSH. The changes accommodate the default usermode networking configuration in Linux, which uses a different IP address and port for SSH connections. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cfergeau - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be good to also update the
crc ssh
command example if that is affected. - Consider mentioning the network mode setting in the documentation for completeness.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
linux now uses usermode networking by default, so the instructions to ssh into the VM need to be updated.
linux now uses usermode networking by default, so the instructions to
ssh into the VM need to be updated.
Summary by Sourcery
Documentation: