Skip to content

feat(smoketest): env vars for overriding all component image versions #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Mar 10, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1396

How to manually test:

ex:

CRYOSTAT_IMAGE=registry.redhat.io/cryostat-tech-preview/cryostat-rhel8@sha256:206aae11709e8fca8710fab33b77c357dd60ba1ca741d54d7a62fcde70da945f DATASOURCE_IMAGE=registry.redhat.io/cryostat-tech-preview/jfr-datasource-rhel8@sha256:16a141894206f273697abd2e0e988eaa9aafea195128acee69b280f797314aea GRAFANA_IMAGE=registry.redhat.io/cryostat-tech-preview/cryostat-grafana-dashboard-rhel8@sha256:271e0003d048fb3e946b13cf8bb9aa90d0ce144c2825314d3f51a439d76c4b0f REPORTS_IMAGE=registry.redhat.io/cryostat-tech-preview/cryostat-reports-rhel8@sha256:f8308fc99bb23c5ff28e5f74570e8e4709b007fe9125c589c8468b61436cbf9a sh smoketest.sh

Then podman ps or similar to verify that all of the running containers are using the correct images.

For this specific set of images, podman login registry.redhat.io is probably required first.

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Mar 10, 2023
@mergify mergify bot added the safe-to-test label Mar 10, 2023
@andrewazores andrewazores added feat New feature or request and removed needs-triage Needs thorough attention from code reviewers labels Mar 10, 2023
@andrewazores andrewazores requested a review from ebaron March 10, 2023 18:14
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1397-d0a4bfe44c24bf27baf460bf579e8cc045612c36 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1397-9d1d355bf0d8b3fe326a78cf196c0145e970b422 sh smoketest.sh

ebaron
ebaron previously approved these changes Mar 13, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1397-f58d6a5952ed308182b16cd3abd187eb03bd2f6e sh smoketest.sh

@andrewazores
Copy link
Member Author

@ebaron need re-approval please, no changes other than rebasing + commit signing.

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1397-88eda3151c579039c0b9b1ea6ee64ea365477d5f sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1397-63af5567327044b9400770fe385859cc0011e820 sh smoketest.sh

@andrewazores andrewazores merged commit d3fea61 into cryostatio:main Mar 14, 2023
@andrewazores andrewazores deleted the smoketest-images branch March 14, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Request] smoketest.sh environment variables for overriding all container versions
2 participants