-
Notifications
You must be signed in to change notification settings - Fork 31
feat(smoketest): env vars for overriding all component image versions #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb513e5
to
d0a4bfe
Compare
Test image available:
|
d0a4bfe
to
9d1d355
Compare
Test image available:
|
9d1d355
to
0dfdad4
Compare
ebaron
previously approved these changes
Mar 13, 2023
0dfdad4
to
f58d6a5
Compare
Test image available:
|
Signed-off-by: Andrew Azores <[email protected]>
f58d6a5
to
88eda31
Compare
@ebaron need re-approval please, no changes other than rebasing + commit signing. |
Test image available:
|
ebaron
approved these changes
Mar 14, 2023
Test image available:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1396
How to manually test:
ex:
Then
podman ps
or similar to verify that all of the running containers are using the correct images.For this specific set of images,
podman login registry.redhat.io
is probably required first.