Skip to content

fix(graphql): remove non-null constraints for active recs action #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/main/resources/types.graphqls
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,16 @@ type Annotations {

type TargetNode implements Node {
target: ServiceRef!
recordings: Recordings!
mbeanMetrics: MBeanMetrics!
recordings: Recordings
mbeanMetrics: MBeanMetrics

id: Int!
name: String!
nodeType: NodeType!
labels: Object!

doStartRecording(recording: RecordingSettings!): ActiveRecording!
doSnapshot: ActiveRecording!
doStartRecording(recording: RecordingSettings!): ActiveRecording
doSnapshot: ActiveRecording
}

type EnvironmentNode implements Node {
Expand Down Expand Up @@ -119,9 +119,9 @@ type ActiveRecording implements Recording {
metadata: RecordingMetadata!

doArchive: ArchivedRecording!
doStop: ActiveRecording!
doDelete: ActiveRecording!
doPutMetadata(metadata: Object): ActiveRecording!
doStop: ActiveRecording
doDelete: ActiveRecording
doPutMetadata(metadata: Object): ActiveRecording
}

type ArchivedRecording implements Recording {
Expand Down