fix(ssl): fixed env var behaves unexpectedly #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aali309
added
bug
aali309
changed the title
aali309
force-pushed
the
cryostat_disable_ssl
branch
from
5057d2e to
5acb120
Compare
aali309
force-pushed
the
cryostat_disable_ssl
branch
from
5acb120 to
02ec3d4
Compare
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
This looks like the latest push includes some improperly cherry-picked commits from a rebase, or something. The main change itself looks fine now, but please correct the commit history to include only that change. |
|
Test image available: |
|
Test image available: |
aali309
force-pushed
the
cryostat_disable_ssl
branch
from
9a1cc1a to
497a87c
Compare
andrewazores
approved these changes
Jul 4, 2023
|
Test image available: |
|
Test image available: |
mergify bot
pushed a commit
that referenced
this pull request
Jul 4, 2023
(cherry picked from commit 803c132)
andrewazores
pushed a commit
that referenced
this pull request
Jul 4, 2023
(cherry picked from commit 803c132) Co-authored-by: Atif Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1507
Description of the change:
This change allows enabling of SSL when CRYOSTAT_DISABLE_SSL is set to "false"
Motivation for the change:
This change is helpful because users may want to sue a Secure Sockect Layer(SSL) where as he can just pass the environment variable to false i.e < CRYOSTAT_DISABLE_SSL=false>
How to manually test:
CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...CRYOSTAT_DISABLE_SSL=false sh smoketest.sh and test it by < http --verify=no https://localhost:8181/health