Skip to content

feat(auto-rules): JavaScript Rule Match Expressions #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 19, 2021

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jun 29, 2021

Depends on #523

Fixes #540
Closes #413

@andrewazores andrewazores added the feat New feature or request label Jul 6, 2021
@andrewazores andrewazores changed the title [auto-rules] JavaScript Rule Match Expressions WIP feat:(auto-rules): JavaScript Rule Match Expressions Jul 6, 2021
@andrewazores andrewazores changed the title WIP feat:(auto-rules): JavaScript Rule Match Expressions WIP feat(auto-rules): JavaScript Rule Match Expressions Jul 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@andrewazores andrewazores force-pushed the rules-nashorn branch 5 times, most recently from 1c586a0 to 5f072f2 Compare July 9, 2021 15:52
@andrewazores andrewazores changed the title WIP feat(auto-rules): JavaScript Rule Match Expressions feat(auto-rules): JavaScript Rule Match Expressions Jul 9, 2021
@andrewazores andrewazores marked this pull request as ready for review July 9, 2021 16:11
@andrewazores andrewazores force-pushed the rules-nashorn branch 8 times, most recently from 186406d to 65ba6a5 Compare July 12, 2021 18:14
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple of comments.

@andrewazores andrewazores dismissed stale reviews from jan-law and hareetd via 79e2e22 July 19, 2021 21:46
@andrewazores
Copy link
Member Author

Cleanly rebased, approving reviews were all dismissed so I will merge regardless once status checks pass.

@andrewazores andrewazores merged commit cf22d2e into cryostatio:main Jul 19, 2021
@andrewazores andrewazores deleted the rules-nashorn branch July 19, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto rules should offer matching on more than mainClass/targetAlias Document automatic rules API
4 participants