Skip to content

test(targets): Add itest for targets POST and DELETE #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2021
Merged

test(targets): Add itest for targets POST and DELETE #607

merged 3 commits into from
Jul 27, 2021

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Jul 27, 2021

Related #474

Tests the TargetsPostHandler and TargetDeleteHandler.

@jan-law jan-law added the test label Jul 27, 2021
@jan-law jan-law requested a review from andrewazores July 27, 2021 17:32
@jan-law jan-law marked this pull request as ready for review July 27, 2021 18:50
andrewazores
andrewazores reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a rebase.

@andrewazores andrewazores merged commit dee7ebc into cryostatio:main Jul 27, 2021
@jan-law jan-law deleted the itest-targets branch July 29, 2021 14:07
tthvo pushed a commit to tthvo/cryostat-legacy that referenced this pull request Dec 9, 2024
@andrewazores
build(deps): switch S3 HTTP client from urlconnection to apache (cryo…
8f86147 
…statio#607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-law @andrewazores