Rename execution contexts + improve their docs #15936
Open
+192
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Concurrency is restricted to a single thread. Fibers in the same context | ||
| # will never run in parallel to each other but they may still run in parallel | ||
| # to fibers running in other contexts (i.e. in another thread). | ||
| # Fibers running in this context can only run concurrently and never in |
There was a problem hiding this comment.
suggestion: Keep the wording of "the same context. This point out clearly that this refers to specific context instances. Fibers in different instances of Concurrent do run parallel to each other.
Suggested change
| # Fibers running in this context can only run concurrently and never in | |
| # Fibers running in the same context can only run concurrently and never in |
There was a problem hiding this comment.
Weirdly, using "same context" is more confusing to me (it seems to apply to all contexts outside of concurrent).
Maybe "this context instance" or "same context instance" maybe?
Hum, it's not that confusing.
There was a problem hiding this comment.
"the same context instance" would be a bit more precise. But it's also quite a mouthful.
Co-authored-by: Johannes Müller <[email protected]>
straight-shoota
approved these changes
Jun 30, 2025
sbsoftware
reviewed
Jul 1, 2025
Co-authored-by: sbsoftware <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in RFC 2 and in light of #15871 for example, the execution contexts are much more about "how fibers run", either concurrently or in parallel or by themselves (the intent), and have little to do with "threads" that are only the technical mean to achieve parallelism.
A great example is that the isolated context doesn't have the word thread in its name, despite being the only context that guarantees the fiber will always run on the same thread (the fiber owns the thread until it terminates).
This PR renames:
SingleThreadedtoConcurrentMultiThreadedtoParallelIt also refines the documentation of the different types to also insist on the intent, what it means, and what are the actual guarantees given by each context.