Added target to OpenInAppURL object #212
Conversation
| @@ -44,6 +44,9 @@ message OpenInAppURL { | |||
| // OPTIONAL. | |||
| // The headers to be added to the request. | |||
| map<string, string> headers = 4; | |||
| // REQUIRED. | |||
| // Whether the target for the app URL is an iframe or a new page. | |||
| Target target = 5; | |||
There was a problem hiding this comment.
I'm not sure how target fits in here. Eg. doing a POST to a new tab is technically not possible.
ownCloud Web has a option WEB_OPTION_OPEN_APPS_IN_TAB -> `Configures whether apps and extensions should generally open in a new tab. It seems to fulfill the same purpose? In the future, this could also be a per user setting.
There was a problem hiding this comment.
Yes, with this not all combinations are legal, but the scope is for certain applications to go to a new tab/page as opposed to an iframe. We are trying to integrate Overleaf, but the integration would work quite differently than WOPI-based apps, therefore it makes sense (and it is necessary for CSP reasons) to have the user go directly to the app's URL, rather than embedding it in an iframe.
There was a problem hiding this comment.
Ah, ok this is currently not configure for oC Web. Because even if one configures Web to open everything in a new tab, it will open the app inside a iframe via the GET / POSt request.
@micbar this is highly interesting for future integrations
|
@labkode can you also have a look? |
Also added
actionto AppProviderInfo.The exercise here is to demonstrate a different kind of integration, where the app lives on an external cloud and uses its own login and storage. Therefore it can't be embedded in an iframe and the integration is more loose, with the user driving the
Export toandImport fromactions as opposed to a simpleOpen with.