-
Notifications
You must be signed in to change notification settings - Fork 113
Data transfers package #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data transfers package #1321
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
433674c
to
e287e17
Compare
@ishank011 I merged the cs3apis, let's change the dep to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishank011 should we remove the sdk test files?
@labkode Yes we can. I didn't like the idea of calling a remote server to run unit tests in the first place. @Daniel-WWU-IT can you modify these to run on a local reva daemon? |
@ishank011 still one conflict to resolve |
Previously, we had to configure which data transfer protocol to use in the dataprovider service. A previous PR added the functionality to redirect requests to different handlers based on the request method but that would lead to conflicts if multiple protocols don't support mutually exclusive sets of requests. This PR adds the functionality to have multiple such handlers simultaneously and the client can choose which protocol to use.
Depends on cs3org/cs3apis#96, currently uses my fork https://github.com/ishank011/go-cs3apis
InitiateFileUpload
response now looks like: