[tests-only] Implement .drone.env #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://drone.cernbox.cern.ch/cs3org/reva/960/5/6 Looks good - it switches to the correct commit id that is specified in |
|
|
|
@ishank011 IMO CI will pass now. Please review. |
ishank011
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to store the CORE_BRANCH and CORE_COMMITID for tests, the same way as is done in https://github.com/owncloud/ocis/blob/master/.drone.env
The disadvantage of having the commit-id embedded in
.drone.staris that a.drone.starin the PR branch gets used from the PR branch and if there are other, later, changes to.drone.starinmasterthey do not take effect in drone CI. This can lead to confusion about exactly what pipelines ran with what settings in CI.Having
.drone.envmeans that.drone.starcan be much less modified.Note: I had to change to
owncloudci/alpine:latest(like inowncloud/ocis) forcloneOc10TestReposStep()because it used thesourcecommand, andowncloudci/php:7.4complained thatsourcedid not exist!