Skip to content

fix app provider new file action and improve app provider error codes #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 9, 2021
Merged

fix app provider new file action and improve app provider error codes #2210

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4285332
fix app provider new file action and improve app provider error codes
wkloucek Oct 27, 2021
1ebf53f
revert removal of early upload finish for all fs
wkloucek Nov 25, 2021
4f76c5b
update changelog
wkloucek Nov 25, 2021
82958a1
return resourceId directly instead of parts only
wkloucek Nov 25, 2021
14b40b6
fix rebase fail and new file action
wkloucek Nov 26, 2021
3e0c043
revert changes to storage drivers
wkloucek Dec 8, 2021
850506a
create new file by path as long as not all storage providers support …
wkloucek Dec 9, 2021
f4ee18b
remove comments about relative reference
wkloucek Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/http/services/appprovider/appprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,10 @@ func (s *svc) handleNew(w http.ResponseWriter, r *http.Request) {
}

fileRef := &provider.Reference{
ResourceId: parentContainer.Info.Id,
Path: utils.MakeRelativePath(filename),
Path: path.Join(parentContainer.Info.Path, utils.MakeRelativePath(filename)),
// TODO: switch to a relative reference as soon as all storage providers support this
// ResourceId: parentContainer.Info.Id,
// Path: utils.MakeRelativePath(filename),
}

statFileReq := &provider.StatRequest{
Expand Down