Skip to content

fix(schema-compiler): Respect ungrouped alias in measures #9411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR changes the behavior of renderSqlMeasure to respect ungroupedAliases from context for ungrouped measures.

@MazterQyou MazterQyou requested a review from a team as a code owner April 1, 2025 14:51
@MazterQyou MazterQyou force-pushed the schema-compiler/fix-ungrouped-measure-alias branch from 126ea83 to f512b0f Compare April 2, 2025 07:54
@MazterQyou MazterQyou force-pushed the schema-compiler/fix-ungrouped-measure-alias branch from f512b0f to e0a8a61 Compare April 2, 2025 09:48
@MazterQyou MazterQyou force-pushed the schema-compiler/fix-ungrouped-measure-alias branch from e0a8a61 to 59f2fb5 Compare April 2, 2025 09:53
@MazterQyou MazterQyou merged commit f0829d7 into master Apr 2, 2025
57 checks passed
@MazterQyou MazterQyou deleted the schema-compiler/fix-ungrouped-measure-alias branch April 2, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants