Skip to content

feat: introduce "protocol" and "method" props for request param in checkSqlAuth #9525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MikeNitsenko
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Apr 28, 2025
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (940c30f) to head (b0f0318).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/router.rs 50.00% 5 Missing ⚠️
packages/cubejs-api-gateway/src/sql-server.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9525      +/-   ##
==========================================
+ Coverage   80.28%   80.30%   +0.02%     
==========================================
  Files         395      395              
  Lines       97355    97527     +172     
  Branches     2278     2278              
==========================================
+ Hits        78158    78316     +158     
- Misses      18889    18903      +14     
  Partials      308      308              
Flag Coverage Δ
cube-backend 57.50% <0.00%> (-0.01%) ⬇️
cubesql 83.96% <76.19%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr
Copy link
Member

ovr commented Apr 28, 2025

@MikeNitsenko You need to write at least 1 test. Could you please write test via mock in test/sql.test.ts?

image

@MikeNitsenko MikeNitsenko force-pushed the chore-check-sql-auth-new-request-params branch from 74aa71c to 042884f Compare April 30, 2025 06:50
@MikeNitsenko MikeNitsenko changed the title CC-6106 feat: introduce "protocol" and "method" props for request param in checkSqlAuth Apr 30, 2025
@MikeNitsenko MikeNitsenko marked this pull request as ready for review April 30, 2025 18:37
@MikeNitsenko MikeNitsenko requested review from a team as code owners April 30, 2025 18:37
@MikeNitsenko MikeNitsenko requested a review from ovr April 30, 2025 18:38
@MikeNitsenko MikeNitsenko marked this pull request as draft April 30, 2025 18:38
@MikeNitsenko MikeNitsenko marked this pull request as ready for review May 1, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants