Skip to content

Commit d4dd2ce

Browse files
committed
cue/interpreter/wasm: skip tests on evalv3
The entirety of the tests fail on evalv3, seemingly because the external func values do not resolve to builtin values which can be called. For #3662. Signed-off-by: Daniel Martí <[email protected]> Change-Id: I2334563a45c90ed57e34171420182afc59fb7ae5 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211971 Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Marcel van Lohuizen <[email protected]> TryBot-Result: CUEcueckoo <[email protected]>
1 parent 5883337 commit d4dd2ce

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

cue/interpreter/wasm/exe_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ import (
3434
"cuelang.org/go/cue/cuecontext"
3535
"cuelang.org/go/cue/interpreter/wasm"
3636
"cuelang.org/go/cue/parser"
37+
"cuelang.org/go/internal"
38+
"cuelang.org/go/internal/core/runtime"
3739
"cuelang.org/go/internal/cuetest"
3840

3941
"github.com/rogpeppe/go-internal/gotooltest"
@@ -50,6 +52,9 @@ func TestMain(m *testing.M) {
5052

5153
// TestExe tests Wasm using the command-line tool.
5254
func TestExe(t *testing.T) {
55+
if version, _ := (*runtime.Runtime)(cuecontext.New()).Settings(); version == internal.EvalV3 {
56+
t.Skip("TODO: fix these tests on evalv3")
57+
}
5358
root := must(filepath.Abs("testdata"))(t)
5459
wasmFiles := filepath.Join(root, "cue")
5560
p := testscript.Params{

cue/interpreter/wasm/wasm_test.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525
"cuelang.org/go/cue/errors"
2626
"cuelang.org/go/cue/format"
2727
"cuelang.org/go/cue/interpreter/wasm"
28+
"cuelang.org/go/internal"
2829
"cuelang.org/go/internal/cuetxtar"
2930
)
3031

@@ -37,7 +38,9 @@ func TestWasm(t *testing.T) {
3738

3839
test.Run(t, func(t *cuetxtar.Test) {
3940
ctx := cuecontext.New(cuecontext.Interpreter(wasm.New()))
40-
41+
if version, _ := t.Runtime().Settings(); version == internal.EvalV3 {
42+
t.Skip("TODO: fix these tests on evalv3")
43+
}
4144
if t.HasTag("cuecmd") {
4245
// if #cuecmd is set the test is only for the CUE command,
4346
// not the API, so skip it.

0 commit comments

Comments
 (0)