Skip to content

evalv3: enable evalv3 by default #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
myitcv opened this issue Jan 9, 2025 · 2 comments
Closed

evalv3: enable evalv3 by default #3662

myitcv opened this issue Jan 9, 2025 · 2 comments
Assignees
@mvdan
Labels
evaluator evalv3 issues affecting only the evaluator version 3 FeatureRequest New feature or request

Comments

@myitcv
Copy link
Member

myitcv commented Jan 9, 2025

This is a tracking issue for the enabling of evalv3 by default, whether guarded by language version of not.
@myitcv myitcv added FeatureRequest New feature or request evaluator evalv3 issues affecting only the evaluator version 3 labels Jan 9, 2025
@mvdan mvdan moved this to v0.12.0-alpha.3 in Release v0.12 Jan 10, 2025
@mvdan mvdan mentioned this issue Jan 20, 2025
Closed
@mvdan mvdan removed this from Release v0.12 Jan 22, 2025
@myitcv myitcv added tmp/eval and removed tmp/eval labels Feb 15, 2025
@mpvl mpvl removed the evalv3 issues affecting only the evaluator version 3 label Feb 16, 2025
@mpvl
Copy link
Member

mpvl commented Feb 16, 2025

Not technically an evalv3 problem distinct of v2, so removing that label.

This was referenced Mar 20, 2025
Closed
Closed
@mvdan mvdan added the evalv3 issues affecting only the evaluator version 3 label Mar 21, 2025
@mvdan mvdan self-assigned this Mar 21, 2025
cueckoo pushed a commit that referenced this issue Mar 24, 2025
@mvdan
internal/core/adt: disable tests on evalv3 where they fail
5883337 
TestClosedness and TestOptionalTypes fail in their entirety on evalv3.

For #3662.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: Ifbb2959f303f8904c91f3c3d3f3976a5dfa311d8
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211970
Reviewed-by: Marcel van Lohuizen <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
cueckoo pushed a commit that referenced this issue Mar 24, 2025
@mvdan
cue/interpreter/wasm: skip tests on evalv3
d4dd2ce 
The entirety of the tests fail on evalv3,
seemingly because the external func values do not resolve
to builtin values which can be called.

For #3662.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I2334563a45c90ed57e34171420182afc59fb7ae5
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211971
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
cueckoo pushed a commit that referenced this issue Mar 24, 2025
@mvdan
cue: skip two tests failing on evalv3
5e5179c 
For #3662.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I9f737a2278346206f740df9fae1e490a37091756
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211972
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
cueckoo pushed a commit that referenced this issue Mar 24, 2025
@mvdan
cmd/cue: prepare testscripts for evalv3 being on by default
a78b158 
A few tests covered both evalv2 and evalv3, but in a way that assumed
the default being evalv2, so make sure they explicitly disable
and then enable evalv3.

Two `cmd cue` tests fail on evalv3, which suggests there are bugs
to be figured out; disable them and leave TODOs.

`cue exp gengotypes` sadly panics on evalv3. Disable it with a TODO,
and we will file an issue for that shortly given its severity.

For #3662.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: Ic18ffb815ab67e4b265200cd18ca7c19bf06ae64
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211973
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>
@myitcv
Copy link
Member Author

myitcv commented Mar 24, 2025

I'll just have a 🥳 here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdan mvdan

Labels
evaluator evalv3 issues affecting only the evaluator version 3 FeatureRequest New feature or request
Projects
Release v0.13
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@myitcv @mvdan @mpvl