cuelang.org: code-tabs height should be specified in lines-of-text, not pixels

[jpluscplusm]

What page were you looking at?

https://cuelang.org/examples/shortcodes/code-tabs/#attributes-on-code-tabs

What version of the site were you looking at?

cue-lang/cuelang.org@6ccc4f0

What did you do?

What did you expect?

I expected that the height attribute on code-tabs would be specified in a unit about which I, an author, had context-specific information, and could provide meaningful input. Such a unit might be "lines of text to display".

What did you see instead?

The attribute is specified in pixels, which I can only provide a broad estimate for and which seems brittle given that text sizes can vary across user's screens, font selections, and site UI changes.

More info

We don't yet use the height attribute on the site, so changing its units (i.e. backwards compatibility) isn't a problem:

$ git grep 'height=' hugo/content/en/docs/**/*.md || echo Not found
Not found

[JorindeUsMedia]

This was done because in css there was nothing to set the amount of lines. But there is a webkit css property called "line-clamp" which is now working in all webkit browsers:
https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-line-clamp

We could have a look at this: define nr of lines via the height attribute and solve it using webkit-line-clamp.

[JorindeUsMedia]

Discussed: Change pixel value to amount of line
We can add a unit
height="500px"
height="10 lines"

or always use lines:
height="10"

or maybe
lines="10" and keep height in px ? (when both are filled in Lines wins from height)

backwards compatibliy: it's not used now (we think) but if it is we can easily change the ones that use height to have amount of lines instead of pixels: or add the px unit in case we go for the unit notation

[JorindeUsMedia]

Conclusion from comment above:
Height stays the same as it is
We will add a new property "lines" for the amount of lines
When both lines & height are filled in lines wins