-
Notifications
You must be signed in to change notification settings - Fork 312
cue def --inline-imports regression in v0.11 #3646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
git bisect says that the regression was introduced in this commit: a50fa63 |
@gotwarlost thanks for another great repro. I've confirmed this does indeed bisect to a50fa63. I've tweaked your testscript slightly to make it easier to run in a |
FWIW this problem occurs for both evalv2 and evalv3. |
cueckoo
pushed a commit
that referenced
this issue
Jan 21, 2025
Issue #3646 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: Iff6774ef8219fec53afe355c51b088681bc35f61 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207401 Reviewed-by: Daniel Martí <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Unity-Result: CUE porcuepine <[email protected]>
cueckoo
pushed a commit
that referenced
this issue
Jan 22, 2025
Issue #3646 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: Iff6774ef8219fec53afe355c51b088681bc35f61 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207401 Reviewed-by: Daniel Martí <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Unity-Result: CUE porcuepine <[email protected]> Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207626 Reviewed-by: Paul Jolly <[email protected]>
cueckoo
pushed a commit
that referenced
this issue
Jan 22, 2025
If a non-rooted/anonymous node uses structure sharing, we need to treat the references within the structure-shared node as non-rooted as well. The reasons for this is that otherwise this reference does not have an addressable location. It is hard to detect this from the context of a structure- shared node. In CL https://cuelang.org/cl/1202268, this was done by investigating the context. For this we need to be slightly more aggressive picking the current reference. Test changes: - issue2247: reverted to the state before cl/1202268. Not great, but not wrong. - selfref: one good improvement, one regression. - import: reverts to V2, but not a huge deal - let2: now refers to references in let, instead of original. This is not wrong per se, and maybe even desirable. Fixes #3646 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: I88f89720be95547bb8f897c34f041af6fb8d65eb Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207402 TryBot-Result: CUEcueckoo <[email protected]> Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Matthew Sackman <[email protected]> Reviewed-by: Daniel Martí <[email protected]> Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207627 Reviewed-by: Paul Jolly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of CUE are you using (
cue version
)?Does this issue reproduce with the latest stable release?
yes
What did you do?
Ran a testscript test with the following contents:
What did you expect to see?
A passing test
What did you see instead?
Testing on other versions
The text was updated successfully, but these errors were encountered: