Hugo: add searchTerm option to search shortcode #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
3eb1865 to
a8713db
Compare
JorindeUsMedia
requested changes
Apr 29, 2025
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
a8713db to
2441f96
Compare
JorindeUsMedia
approved these changes
May 7, 2025
There was a problem hiding this comment.
The only edge case which I found while testing: Remove all preselected terms & tags: the search will reset to the preselected filters & term. There is no way to empty it. But I don't know how to fix that because on page load there is also no search term and than the preselected term kicks in: that's what we want. There's no way to know now if the user emptied it or if we started fresh. It's also preselected for a reason :)
jpluscplusm
requested changes
May 12, 2025
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
2441f96 to
64a4e58
Compare
jpluscplusm
requested changes
May 12, 2025
* Add searchTerm to example page * Pass searchTerm from search shortcode, through search partial, to filter partial * Set initial searchItem with search filter To test: * Navigate to /examples/shortcodes/search and verify that the search results are accurate. Fixes cue-lang/cue#3566 Signed-off-by: juanstelling <[email protected]>
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
64a4e58 to
9bc6197
Compare
jpluscplusm
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
Fixes cue-lang/cue#3566