#218 - Correctly resolve relative local paths pointing to patch files from dependencies - Follow up #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2019
|
Is this just waiting on the test coverage? |
|
I would also love to see some progress on this. Anything we can do to push it forward? |
|
Yes I think increasing the test coverage would be a nice and the maintainer will be pleased. |
|
@drupol unfortunately I've never worked with coveralls before and I'm not sure what would be required to increase that coverage stat. |
|
You do not need coveralls, you just need to write more tests, coveralls will compute the coverage by itself. |
impl
added a commit
to municipalbroadband/cweagans-composer-patches
that referenced
this pull request
Jan 11, 2020
|
This PR seems to be obsolete due to #267. |
|
I would be happy to see this PR merged, how can I help ? @drupol |
|
Resolving patches from dependencies isn't a thing in 2.x, so neither is applying patches stored relative to the root of a dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of PR #218.