feat(Tile/Dimmer): restart cycle if torch was disabled #78
Conversation
Changes the DimmerSettingsTile to always start from the dimmest mode if the toch is disabled. Previously it would continue from the last mode, which was confusing to the user, since suddenly the tile acted different when tapped.
Fixes an issue, where if the torch was externally disabled, the mode should continue to show the (now outdated) mode instead of off.
|
Hi, thanks for your contribution. https://i.imgur.com/Etr6vvx.mp4 Does it work on your side? |
|
Yup, works pretty much perfectly over here, screen-20240909-222648.trimmed.mp4 |
|
I've investigated this issue and it seems that the settings tiles work fine without problems when being used on their one, so by not having both of them in the quick settings pane. I will take a look at #79 and try to fix this issue there. |
cyb3rko
force-pushed
the
main
branch
2 times, most recently
from
ab94d4e to
1eda79a
Compare
# Conflicts: # app/src/main/kotlin/com/cyb3rko/flashdim/tiles/DimmerSettingsTile.kt
|
@FineFindus I tried to apply your changes to the current state of the app. Could you please test out if it works for you as expected? |
|
The reset works, however both the min and half stage now show the text of the half stage. |
|
Thank you. I think I've found the fix, will test it in a bit. |
|
Could you test again please? |
|
Works fine for me now, I will merge it. |
Changes the DimmerSettingsTile to always start from the dimmest mode when the torch is disabled. Previously it would continue from the last mode, which was confusing for the user as the tile would suddenly behave differently when tapped. This could happen if the user was using the tile and then disabled the torch through another application (e.g., the At a Glance widget on Pixels).
The tile will also update to show if the torch has been disabled by other means.