Skip to content

feat: makes dagger version required #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025
Merged

feat: makes dagger version required #176

merged 3 commits into from
Feb 25, 2025

Conversation

jpadams
Copy link
Contributor

@jpadams jpadams commented Feb 25, 2025

This implements the decision to move to this approach:

  • don't use a specific version of Dagger by default (e.g. 0.15.4, 0.16.2).
  • rather, users must specify a version or specify 'latest', there is no default, this is new behavior so major version bump
  • we should release as version 8 and use 8.0.0 (vs v8.0.0) style from here forward for GH's immutable actions compat

Updates README.md to remove version numbers and make it evergreen thus we don't need a module to bump versions anymore.

Copy link
Contributor

@kpenfound kpenfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! Thanks for cleaning up

@jpadams jpadams merged commit e47aba4 into main Feb 25, 2025
5 checks passed
@jpadams jpadams deleted the version-required branch February 25, 2025 07:28
Copy link
Member

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks @jpadams, this should hugely simplify it! ❤️

@esafak
Copy link

esafak commented Mar 17, 2025

How do you suggest automating updating of the dagger version with this update? Dependabot can update the Action but won't touch the dagger argument, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants