refactor: move logout to accountPageItems and reduce code duplication
#4481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omBratteng
requested review from
rebelchris,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the logout functionality by moving it into accountPageItems to reduce duplicated code in the profile settings menu.
- Consolidates logout into accountPageItems.
- Removes the separate mobile-specific logout block.
- Adjusts the use of separators in the menu list based on item order.
Comments suppressed due to low confidence (1)
packages/shared/src/components/profile/ProfileSettingsMenu.tsx:239
- [nitpick] The removal of the mobile-specific typography override for the logout item may affect the mobile UX. Confirm that the mobile styling has been addressed elsewhere or add appropriate styling if needed.
- <ProfileSection
- items={[
- {
- title: 'Log out',
- icon: ExitIcon,
- onClick: () => logout(LogoutReason.ManualLogout),
- ...(isMobile && {
- typography: {
- type: TypographyType.Body,
- color: TypographyColor.Primary,
- },
- }),
- },
- ]}
- />
omBratteng
commented
May 9, 2025
| logout: { | ||
| title: 'Log out', | ||
| icon: ExitIcon, | ||
| onClick: () => logout(LogoutReason.ManualLogout), |
There was a problem hiding this comment.
logout from AuthContext is the same as the one from useAuthContext (latter just sets it in its context 🙈)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moves the logout section into
accountPageItemsand reduce code duplicationPreview domain
https://refactor-simplify-settings-menu.preview.app.daily.dev