Skip to content

fix: storybook #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

fix: storybook #4495

merged 3 commits into from
May 15, 2025

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented May 15, 2025 •
edited
Loading

Changes

  • For some reason, the build on storybook fails due to importing the sanitize directly from the package.
  • Although it is kinda better because we have a common function that we use properly when sanitizing content.
  • I think there is a deeper issue with package compats with storybook and our app, although I don't think it is worth half a day of investigation just to fix it.

Screenshot 2025-05-16 at 12 10 19 AM

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://chore-storybook.preview.app.daily.dev

@vercel Vercel
Copy link

vercel bot commented May 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview May 15, 2025 4:18pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) May 15, 2025 4:18pm

@sshanzel sshanzel marked this pull request as ready for review May 15, 2025 16:10
@sshanzel sshanzel requested a review from a team as a code owner May 15, 2025 16:10
@sshanzel sshanzel merged commit 0bce0a2 into main May 15, 2025
10 checks passed
@sshanzel sshanzel deleted the chore-storybook branch May 15, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capJavert capJavert capJavert approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

@AmarTrebinjac AmarTrebinjac Awaiting requested review from AmarTrebinjac AmarTrebinjac is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshanzel @capJavert