Skip to content

feat: enable skip on information screens #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: enable skip on information screens #4496

wants to merge 6 commits into from

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented May 15, 2025

Changes

  • There are two things that was introduced here:
    • First is the support on Info screens to have a "Skip" button.
      • This also introduced support for custom copy for the button and its placement.
      • See it in action through the recording.
    • Second is the support for destination with next value.
      • This change will make it easier to track what was the previous intention for enabling the Skip. Whether it was just to move on to the next step, or to actually jump to another screen. This helps when product is trying to move things around.
      • Everything involved in this change was isolated in this commit. I encourage you to take a peek at this first to make it easier to identify the distinction between the changes: d3ec265

Screenshot 2025-05-16 at 1 29 30 AM
Screenshot 2025-05-16 at 1 24 15 AM

See it in action:
https://github.com/user-attachments/assets/6f8353d5-04e5-4907-a263-4cfe2a3db52b

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Jira ticket

MI-895

Preview domain

https://mi-895.preview.app.daily.dev

Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview May 16, 2025 9:38am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) May 16, 2025 9:38am

| typeof COMPLETED_STEP_ID
| typeof NEXT_STEP_ID;
cta?: string;
placement?: 'default' | 'bottom' | 'top';
Copy link
Contributor

@ilasw ilasw May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we putting cta and placement in transition? 👀

imo those infos should be added in step.parameters inside a dedicated property, something like step.parameters.ctas:

Array<{ label: '', type: FunnelStepTransitionType, placement: '...' }>

or (for easier access)

step.parameters[PLACEMENT] : { label: '', type: FunnelStepTransitionType } 

Doing so we are separating the UI infos from the logic ones. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants