-
Notifications
You must be signed in to change notification settings - Fork 262
feat: enable skip on information screens #4496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| typeof COMPLETED_STEP_ID | ||
| typeof NEXT_STEP_ID; | ||
cta?: string; | ||
placement?: 'default' | 'bottom' | 'top'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we putting cta
and placement
in transition? 👀
imo those infos should be added in step.parameters
inside a dedicated property, something like step.parameters.ctas
:
Array<{ label: '', type: FunnelStepTransitionType, placement: '...' }>
or (for easier access)
step.parameters[PLACEMENT] : { label: '', type: FunnelStepTransitionType }
Doing so we are separating the UI infos from the logic ones. Wdyt?
Changes
destination
withnext
value.See it in action:
https://github.com/user-attachments/assets/6f8353d5-04e5-4907-a263-4cfe2a3db52b
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-895
Preview domain
https://mi-895.preview.app.daily.dev