Skip to content

feat: subscription before registration in funnel #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2025

Conversation

AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented May 16, 2025

Changes

This is the intermediate (final) branch for the subscription before registration RFC

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Jira ticket

MI-881

Preview domain

https://mi-881-sub-before-registration.preview.app.daily.dev

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview May 16, 2025 0:28am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) May 16, 2025 0:28am

{subscriberEmail && (
<Alert
type={AlertType.Info}
title={`Please sign up using the email address ${subscriberEmail} to claim your daily.dev Plus subscription.`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we sanitize?

@sshanzel sshanzel merged commit dca7ed6 into main May 16, 2025
10 checks passed
@sshanzel sshanzel deleted the MI-881-sub-before-registration branch May 16, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants