Skip to content

fix: use annual for the card comparison #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

fix: use annual for the card comparison #4498

merged 2 commits into from
May 16, 2025

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented May 16, 2025 •
edited by github-actions bot
Loading

Changes

  • We removed the annual special and the comparison card was dependent to it. Made the state kept at loading.
  • Quick fix is to set it to annual, later on we can add this as a configuration.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://fix-onboarding.preview.app.daily.dev

@sshanzel sshanzel requested a review from a team as a code owner May 16, 2025 06:07
@vercel Vercel
Copy link

vercel bot commented May 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview May 16, 2025 6:12am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) May 16, 2025 6:12am

@sshanzel sshanzel merged commit b8c00fe into main May 16, 2025
10 checks passed
@sshanzel sshanzel deleted the fix-onboarding branch May 16, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoshamun idoshamun idoshamun approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

@AmarTrebinjac AmarTrebinjac Awaiting requested review from AmarTrebinjac AmarTrebinjac is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshanzel @idoshamun