fix: symlink already exists now

[henryiii]

Fixes #419.

[gschaffner]

Can confirm that this fix works for my group once index.js has been recompiled.

For documentation's sake: it looks like GitHub-hosted Linux runners had PyPy2 updated from 7.3.8 to 7.3.9 a few days ago (actions/runner-images@1ede808, actions/runner-images@8863b25). PyPy 7.3.9 added a new pypy2 alias for pypy [ref], so I don't think setup-nox needs to create the symlink itself anymore.

For backwards-compatability though, perhaps setup-nox should still create a symlink if PyPy2 < 7.3.9. (Or simply try-catch the creation of the symlink instead of parsing the version string.) This won't ever occur on GitHub-hosted runners, but presumably folks may be using setup-nox on self-hosted runners.

[daisylb]

Thanks so much for filing this one!

For backwards-compatability though, perhaps setup-nox should still create a symlink if PyPy2 < 7.3.9. (Or simply try-catch the creation of the symlink instead of parsing the version string.) This won't ever occur on GitHub-hosted runners, but presumably folks may be using setup-nox on self-hosted runners.

I agree with this, and I'd be more comfortable merging this if we maybe just checked to see if the symlink exists and create it if not. I'm less worried about self-hosted runners breaking, but if we can avoid it that's definitely better.

[henryiii]

Fixed in #421! Thanks! Needs a release though (probably after pinned deps get bumped?)