Update minimum CMake version to 3.12; support CMake 4.0 #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 4.0 drops support for CMake <3.5, so minimum versions need to be adjusted for forward compatibility. As long as we are touching the minimum version, let’s advance to 3.12, which can be considered the oldest “modern” CMake release, and which is available in all known supported Linux distributions today.
Mengna-Li
reviewed
Apr 2, 2025
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 2.8.11) | |||
| cmake_minimum_required(VERSION 3.12) | |||
There was a problem hiding this comment.
Suggested change
| cmake_minimum_required(VERSION 3.12) | |
| cmake_minimum_required(VERSION 3.12...3.5) |
Suggested change
| cmake_minimum_required(VERSION 3.12) | |
| cmake_minimum_required(VERSION 3.12) |
There was a problem hiding this comment.
I’m confused. The first suggestion seems to change this to a version range, but in the wrong direction (3.12...3.5 instead of 3.5...3.12), and then the second suggestion … changes it back?
If you do have a concrete reason to want to support such old CMake versions, 3.5...3.12 would be a reasonable alternative to 3.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 4.0 drops support for CMake <3.5, so minimum versions need to be adjusted for forward compatibility. As long as we are touching the minimum version, let’s advance to 3.12, which can be considered the oldest “modern” CMake release, and which is available in all known supported Linux distributions today.