Remove all types of imports/requires #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
macklinu
reviewed
Jan 5, 2017
|
|
||
| it("also handles require style imports", () => { | ||
| const before = ` | ||
| const { danger, warn, fail, message } from 'danger' |
There was a problem hiding this comment.
I'm not sure if this is valid syntax/tests what your it() description states. The require imports would look like:
const { danger, warn, fail, message } = require('danger')There was a problem hiding this comment.
Nice one, good code reviewing!
Current coverage is 0.00% (diff: 100%)@@ master #82 diff @@
===================================
Files 4 4
Lines 35 35
Methods 1 1
Messages 0 0
Branches 7 7
===================================
Hits 0 0
Misses 35 35
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that
requireimports even exist, so when I was creating the Dangerfile for Jest I realized I needed to add this in 👍--
Note: Jest is currently infinitely looping on
yarn run jest -- --watch- I assume it's the code coverage stuff that is triggering a new run, will try dig into it tomorrow.