Skip to content

Switch to tsc #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Switch to tsc #170

merged 2 commits into from
Mar 6, 2020

Conversation

nikolay-borzov
Copy link
Collaborator

@nikolay-borzov nikolay-borzov commented Feb 27, 2020

  • Replace babel with tsc. Afterall we use TypeScript, why not use all its features.
  • Generate source maps with sourcesContent set
  • Move exported types to types.d.ts
  • Amend mocha configuration to use ts-node.
  • Amend nyc configuration. Follow nyc-config-typescript instructions
  • Add @nikolay-borzov as a maintainer in package.json
  • Specify minimal supported node version in package.json

- Replace `babel` with `tsc`. Afterall we use TypeScript, why not use all its features.
- Generate source maps
- Move exported types to `types.d.ts`
- Amend `mocha` configuration to use `ts-node`.
- Amend `nyc` configuration. Follow [nyc-config-typescript instructions](https://www.npmjs.com/package/@istanbuljs/nyc-config-typescript)
- Add @nikolay-borzov as a maintainer in `package.json`
- Specify minimal supported node version in `package.json`
@coveralls
Copy link

coveralls commented Feb 27, 2020

Coverage Status

Coverage increased (+0.2%) to 98.113% when pulling f041e45 on switch-to-tsc into 7cef71b on master.

@nikolay-borzov nikolay-borzov requested a review from danvk February 27, 2020 19:08
Copy link
Collaborator Author

@nikolay-borzov nikolay-borzov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, LGTM

- Add `sourcesContent` to source maps
@nikolay-borzov nikolay-borzov added this to the 2.4.0 milestone Mar 5, 2020
@nikolay-borzov nikolay-borzov merged commit db6bf38 into master Mar 6, 2020
@nikolay-borzov nikolay-borzov deleted the switch-to-tsc branch March 6, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants