-
Notifications
You must be signed in to change notification settings - Fork 518
Dapr state store clickhouse #3675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mehmet TOSUN <[email protected]>
Thanks @middt, implementation generally looks good to me! Would it be possible to add conformance tests for this too? It seems like we should be able to spin up a click house docker compose. |
…tation Signed-off-by: Mehmet TOSUN <[email protected]>
…tion handling Signed-off-by: Mehmet TOSUN <[email protected]>
… connection handling Signed-off-by: Mehmet TOSUN <[email protected]>
1b2a8de
to
2c8934c
Compare
Thank you for the feedback! @JoshVanL I've implemented the conformance tests for the ClickHouse state store in this PR:
The tests verify all the key functionality including:
I've also addressed authentication issues by properly configuring username and password in both the Docker Compose setup and the state store implementation. All unit tests are now passing, confirming that the implementation works correctly with the ClickHouse server. |
Signed-off-by: Mehmet TOSUN <[email protected]>
Signed-off-by: Mehmet TOSUN <[email protected]>
Thanks @middt, I think the only thing left is to do a Appreciate the work on this! |
Signed-off-by: Mehmet TOSUN <[email protected]>
Done :) ! Just ran |
@middt - mind resolving the conflicts with |
46a191c
to
fb148f1
Compare
Hi @cicoyle, I've resolved the conflicts in go.mod and go.sum by accepting the changes from the main branch, which includes the latest dependency updates. The changes have been pushed to the branch. The main updates include:
All tests are passing and the implementation remains unchanged. The PR should now be ready for review. |
Description
This PR adds a new state store component for ClickHouse, a column-oriented database management system. The ClickHouse state store component provides the following features:
Key implementation details:
Implementation Details
The component includes:
State store implementation (
clickhouse.go
)Tests (
clickhouse_test.go
)Configuration options:
Checklist
Testing Done
Tests were run against ClickHouse v23.8 using the official Go driver.
Additional Notes