Skip to content

Updated sqlserver auth to utilize default scope. #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Updated sqlserver auth to utilize default scope. #3698

merged 2 commits into from
Apr 17, 2025

Conversation

MikelRev
Copy link
Contributor

@MikelRev MikelRev commented Mar 12, 2025 •
edited
Loading

Description

I've updated the Scope selection code for sqlserver statestore auth when using azure auth. The relevant documentation can be found here https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-client-creds-grant-flow. Basically this scope flow is wrong unless its appended with "/.default". We see this exact method used for the Postgres statestore go file when using azure auth.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #_3189

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@MikelRev MikelRev requested review from a team as code owners March 12, 2025 15:29
@alicejgibbons alicejgibbons mentioned this pull request Mar 12, 2025
Open
cicoyle
cicoyle previously approved these changes Mar 31, 2025
View reviewed changes
@alicejgibbons
Copy link

Can you fix DCO @MikelRev. Solace test seems to be failing everywhere cc @cicoyle

@MikelRev
Updated sqlserver auth to utilize default scope.
55fe494 
(cherry picked from commit 2df8349)
Signed-off-by: MikelRev <[email protected]>
@MikelRev MikelRev force-pushed the issues/3189/Fix-SQL-State-Store-AD-Auth branch from ca22a56 to 55fe494 Compare April 14, 2025 14:59
@MikelRev
Copy link
Contributor Author

Can you fix DCO @MikelRev. Solace test seems to be failing everywhere cc @cicoyle

@alicejgibbons I think I managed to fix it. Let me know if anything else is needed on my end.

@yaron2 yaron2 merged commit 31a2088 into dapr:main Apr 17, 2025
89 of 90 checks passed
abossard pushed a commit to abossard/components-contrib that referenced this pull request Apr 29, 2025
@MikelRev @yaron2
Updated sqlserver auth to utilize default scope. (dapr#3698)
af31fae 
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: Andre Bossard <[email protected]>
abossard pushed a commit to abossard/components-contrib that referenced this pull request Apr 29, 2025
Squashed commit of the following:
5642742 
commit 3549843
Author: Josh van Leeuwen <[email protected]>
Date:   Mon Mar 24 17:50:50 2025 -0300

    go.mod: CVE updates (dapr#3713)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 9a11502
Author: Cassie Coyle <[email protected]>
Date:   Wed Apr 23 07:33:24 2025 -0500

    Add baggage header support to http binding (dapr#3723)

    Signed-off-by: Cassandra Coyle <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 8014a1d
Author: Josh van Leeuwen <[email protected]>
Date:   Wed Mar 26 19:55:55 2025 -0300

    CVE go mod dep update (dapr#3716)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 72ffcd1
Author: Josh van Leeuwen <[email protected]>
Date:   Mon Mar 24 17:50:50 2025 -0300

    go.mod: CVE updates (dapr#3713)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 12be96f
Author: Yaron Schneider <[email protected]>
Date:   Wed Jan 29 13:41:28 2025 -0800

    Add deepseek support, update Go to 1.23.5 (dapr#3659)

    Signed-off-by: yaron2 <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit a00c8f3
Merge: a395f74 397766a
Author: Andre Bossard <[email protected]>
Date:   Tue Apr 29 11:41:27 2025 +0200

    Merge branch 'dapr:main' into supporting_more_properties_for_rabbitmq_on_main

commit a395f74
Author: Andre Bossard <[email protected]>
Date:   Mon Apr 28 10:33:59 2025 +0200

    Refactor tryGetProperty to use strings.EqualFold for case-insensitive key matching

    Signed-off-by: Andre Bossard <[email protected]>

commit 1d4f3a1
Author: Anton Troshin <[email protected]>
Date:   Thu Apr 24 15:19:04 2025 -0500

    Support Oracle Connect Descriptors (dapr#3800)

    Signed-off-by: Anton Troshin <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 4630f5c
Author: Anton Troshin <[email protected]>
Date:   Wed Apr 23 07:34:59 2025 -0500

    Solace pubsub conformance test fix (dapr#3802)

    Signed-off-by: Anton Troshin <[email protected]>
    Co-authored-by: Yaron Schneider <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit ed3f7a8
Author: Cassie Coyle <[email protected]>
Date:   Wed Apr 23 07:33:24 2025 -0500

    Add baggage header support to http binding (dapr#3723)

    Signed-off-by: Cassandra Coyle <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit af31fae
Author: MikelRev <[email protected]>
Date:   Thu Apr 17 11:54:52 2025 -0400

    Updated sqlserver auth to utilize default scope. (dapr#3698)

    Co-authored-by: Yaron Schneider <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit c5a0407
Author: Andre Bossard <[email protected]>
Date:   Wed Apr 16 13:39:26 2025 +0200

    Fix metadata handling by removing unnecessary value escaping in RabbitMQ message processing

    Signed-off-by: Andre Bossard <[email protected]>

commit 5bcb186
Author: Andre Bossard <[email protected]>
Date:   Wed Apr 16 13:13:24 2025 +0200

    Refactor RabbitMQ metadata handling to use case-insensitive key retrieval

    Signed-off-by: Andre Bossard <[email protected]>

commit 4f17a7f
Author: Emmanuel Auffray <[email protected]>
Date:   Thu Apr 10 10:06:37 2025 +1200

    Adding GoogleAI models too (dapr#3689)

    Signed-off-by: Emmanuel Auffray <[email protected]>
    Co-authored-by: Josh van Leeuwen <[email protected]>
    Co-authored-by: Yaron Schneider <[email protected]>
    Co-authored-by: Cassie Coyle <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 652c733
Author: Josh van Leeuwen <[email protected]>
Date:   Wed Mar 26 19:55:55 2025 -0300

    CVE go mod dep update (dapr#3716)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 71e9a4b
Author: Josh van Leeuwen <[email protected]>
Date:   Mon Mar 24 17:50:50 2025 -0300

    go.mod: CVE updates (dapr#3713)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 621f7ef
Author: Emmanuel Auffray <[email protected]>
Date:   Mon Mar 24 05:38:17 2025 +1300

    Adding Ollama as a conversation component for local dev/running of LLMs (dapr#3688)

    Signed-off-by: Emmanuel Auffray <[email protected]>
    Co-authored-by: Mike Nguyen <[email protected]>
    Co-authored-by: Yaron Schneider <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 229524f
Author: Emmanuel Auffray <[email protected]>
Date:   Sat Mar 22 00:52:15 2025 +1300

    Fix reference links of conversation components (dapr#3690)

    Signed-off-by: Emmanuel Auffray <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 9dbe6e3
Author: Andre Bossard <[email protected]>
Date:   Wed Apr 16 12:19:53 2025 +0200

    Add metadata handling for RabbitMQ messages and corresponding test

    Signed-off-by: Andre Bossard <[email protected]>

commit 3f0ec0b
Author: Andre Bossard <[email protected]>
Date:   Thu Mar 20 03:25:29 2025 +0100

    Add RabbitMQ metadata properties test and configuration

    Signed-off-by: Andre Bossard <[email protected]>

commit b6acda8
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 12:25:31 2025 +0100

    Add integration test for publishing metadata properties to RabbitMQ

    Signed-off-by: Andre Bossard <[email protected]>

commit f726110
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 09:26:49 2025 +0100

    Refactor RabbitMQ publishing: consolidate metadata application into a single function

    Signed-off-by: Andre Bossard <[email protected]>

commit 4cb5600
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 09:16:14 2025 +0100

    Refactor RabbitMQ metadata handling: consolidate metadata retrieval into common package

    Signed-off-by: Andre Bossard <[email protected]>

commit 069b12f
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 08:12:25 2025 +0100

    Refactor metadata function names for consistency: update messageId and correlationId to messageID and correlationID

commit d508479
Merge: af3fca0 d8ac01b
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 07:58:36 2025 +0100

    Merge branch 'dapr:main' into supporting_more_properties_for_rabbitmq_on_main

commit af3fca0
Merge: 57ae111 637d18d
Author: Andre Bossard <[email protected]>
Date:   Wed Mar 12 03:28:26 2025 -0700

    Merge branch 'main' into supporting_more_properties_for_rabbitmq_on_main

commit 57ae111
Merge: d0c75f6 2997e47
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 4 08:49:52 2025 +0100

    Merge branch 'dapr:main' into supporting_more_properties_for_rabbitmq_on_main

commit d0c75f6
Author: Andre Bossard <[email protected]>
Date:   Wed Feb 5 11:43:03 2025 +0100

    Add support for messageId, correlationId, and type in RabbitMQ bindings

    Signed-off-by: Andre Bossard <[email protected]>
abossard pushed a commit to abossard/components-contrib that referenced this pull request Apr 29, 2025
Squashed commit of the following:
76ad9bb 
commit 3549843
Author: Josh van Leeuwen <[email protected]>
Date:   Mon Mar 24 17:50:50 2025 -0300

    go.mod: CVE updates (dapr#3713)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 9a11502
Author: Cassie Coyle <[email protected]>
Date:   Wed Apr 23 07:33:24 2025 -0500

    Add baggage header support to http binding (dapr#3723)

    Signed-off-by: Cassandra Coyle <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 8014a1d
Author: Josh van Leeuwen <[email protected]>
Date:   Wed Mar 26 19:55:55 2025 -0300

    CVE go mod dep update (dapr#3716)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 72ffcd1
Author: Josh van Leeuwen <[email protected]>
Date:   Mon Mar 24 17:50:50 2025 -0300

    go.mod: CVE updates (dapr#3713)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 12be96f
Author: Yaron Schneider <[email protected]>
Date:   Wed Jan 29 13:41:28 2025 -0800

    Add deepseek support, update Go to 1.23.5 (dapr#3659)

    Signed-off-by: yaron2 <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit a00c8f3
Merge: a395f74 397766a
Author: Andre Bossard <[email protected]>
Date:   Tue Apr 29 11:41:27 2025 +0200

    Merge branch 'dapr:main' into supporting_more_properties_for_rabbitmq_on_main

commit a395f74
Author: Andre Bossard <[email protected]>
Date:   Mon Apr 28 10:33:59 2025 +0200

    Refactor tryGetProperty to use strings.EqualFold for case-insensitive key matching

    Signed-off-by: Andre Bossard <[email protected]>

commit 1d4f3a1
Author: Anton Troshin <[email protected]>
Date:   Thu Apr 24 15:19:04 2025 -0500

    Support Oracle Connect Descriptors (dapr#3800)

    Signed-off-by: Anton Troshin <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 4630f5c
Author: Anton Troshin <[email protected]>
Date:   Wed Apr 23 07:34:59 2025 -0500

    Solace pubsub conformance test fix (dapr#3802)

    Signed-off-by: Anton Troshin <[email protected]>
    Co-authored-by: Yaron Schneider <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit ed3f7a8
Author: Cassie Coyle <[email protected]>
Date:   Wed Apr 23 07:33:24 2025 -0500

    Add baggage header support to http binding (dapr#3723)

    Signed-off-by: Cassandra Coyle <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit af31fae
Author: MikelRev <[email protected]>
Date:   Thu Apr 17 11:54:52 2025 -0400

    Updated sqlserver auth to utilize default scope. (dapr#3698)

    Co-authored-by: Yaron Schneider <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit c5a0407
Author: Andre Bossard <[email protected]>
Date:   Wed Apr 16 13:39:26 2025 +0200

    Fix metadata handling by removing unnecessary value escaping in RabbitMQ message processing

    Signed-off-by: Andre Bossard <[email protected]>

commit 5bcb186
Author: Andre Bossard <[email protected]>
Date:   Wed Apr 16 13:13:24 2025 +0200

    Refactor RabbitMQ metadata handling to use case-insensitive key retrieval

    Signed-off-by: Andre Bossard <[email protected]>

commit 4f17a7f
Author: Emmanuel Auffray <[email protected]>
Date:   Thu Apr 10 10:06:37 2025 +1200

    Adding GoogleAI models too (dapr#3689)

    Signed-off-by: Emmanuel Auffray <[email protected]>
    Co-authored-by: Josh van Leeuwen <[email protected]>
    Co-authored-by: Yaron Schneider <[email protected]>
    Co-authored-by: Cassie Coyle <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 652c733
Author: Josh van Leeuwen <[email protected]>
Date:   Wed Mar 26 19:55:55 2025 -0300

    CVE go mod dep update (dapr#3716)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 71e9a4b
Author: Josh van Leeuwen <[email protected]>
Date:   Mon Mar 24 17:50:50 2025 -0300

    go.mod: CVE updates (dapr#3713)

    Signed-off-by: joshvanl <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 621f7ef
Author: Emmanuel Auffray <[email protected]>
Date:   Mon Mar 24 05:38:17 2025 +1300

    Adding Ollama as a conversation component for local dev/running of LLMs (dapr#3688)

    Signed-off-by: Emmanuel Auffray <[email protected]>
    Co-authored-by: Mike Nguyen <[email protected]>
    Co-authored-by: Yaron Schneider <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 229524f
Author: Emmanuel Auffray <[email protected]>
Date:   Sat Mar 22 00:52:15 2025 +1300

    Fix reference links of conversation components (dapr#3690)

    Signed-off-by: Emmanuel Auffray <[email protected]>
    Signed-off-by: Andre Bossard <[email protected]>

commit 9dbe6e3
Author: Andre Bossard <[email protected]>
Date:   Wed Apr 16 12:19:53 2025 +0200

    Add metadata handling for RabbitMQ messages and corresponding test

    Signed-off-by: Andre Bossard <[email protected]>

commit 3f0ec0b
Author: Andre Bossard <[email protected]>
Date:   Thu Mar 20 03:25:29 2025 +0100

    Add RabbitMQ metadata properties test and configuration

    Signed-off-by: Andre Bossard <[email protected]>

commit b6acda8
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 12:25:31 2025 +0100

    Add integration test for publishing metadata properties to RabbitMQ

    Signed-off-by: Andre Bossard <[email protected]>

commit f726110
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 09:26:49 2025 +0100

    Refactor RabbitMQ publishing: consolidate metadata application into a single function

    Signed-off-by: Andre Bossard <[email protected]>

commit 4cb5600
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 09:16:14 2025 +0100

    Refactor RabbitMQ metadata handling: consolidate metadata retrieval into common package

    Signed-off-by: Andre Bossard <[email protected]>

commit 069b12f
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 08:12:25 2025 +0100

    Refactor metadata function names for consistency: update messageId and correlationId to messageID and correlationID

commit d508479
Merge: af3fca0 d8ac01b
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 18 07:58:36 2025 +0100

    Merge branch 'dapr:main' into supporting_more_properties_for_rabbitmq_on_main

commit af3fca0
Merge: 57ae111 637d18d
Author: Andre Bossard <[email protected]>
Date:   Wed Mar 12 03:28:26 2025 -0700

    Merge branch 'main' into supporting_more_properties_for_rabbitmq_on_main

commit 57ae111
Merge: d0c75f6 2997e47
Author: Andre Bossard <[email protected]>
Date:   Tue Mar 4 08:49:52 2025 +0100

    Merge branch 'dapr:main' into supporting_more_properties_for_rabbitmq_on_main

commit d0c75f6
Author: Andre Bossard <[email protected]>
Date:   Wed Feb 5 11:43:03 2025 +0100

    Add support for messageId, correlationId, and type in RabbitMQ bindings

    Signed-off-by: Andre Bossard <[email protected]>

Signed-off-by: Andre Bossard <[email protected]>
jjcollinge pushed a commit to jjcollinge/components-contrib that referenced this pull request May 12, 2025
@MikelRev @yaron2 @jjcollinge
Updated sqlserver auth to utilize default scope. (dapr#3698)
995df2c 
Co-authored-by: Yaron Schneider <[email protected]>
@marcduiker
Copy link
Contributor

@holopin-bot @MikelRev Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented Jun 11, 2025

Congratulations @MikelRev, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs0gcbl237107l9fako0vas

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaron2 yaron2 yaron2 approved these changes

@cicoyle cicoyle cicoyle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MikelRev @alicejgibbons @marcduiker @yaron2 @cicoyle