bugfix for redis json check #3701
Open
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: theonefx <[email protected]>
JoshVanL
requested changes
Mar 13, 2025
There was a problem hiding this comment.
Thanks @theonefx , please can we add a certification test to cover this fix?
Signed-off-by: theonefx <[email protected]>
Signed-off-by: theonefx <[email protected]>
done |
JoshVanL
approved these changes
Mar 17, 2025
Signed-off-by: theonefx <[email protected]>
|
/test |
JoshVanL
approved these changes
Mar 27, 2025
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
JoshVanL
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Multi method of the state Redis component, when checking whether a request is in JSON format, if the item in the request has contentType=application/json explicitly set, the check will pass. This results in the JSON processing logic being triggered even if clientHasJSON (a flag indicating whether the client supports JSON) is not enabled.