Skip to content

Solace pubsub conformance test fix #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/infrastructure/docker-compose-solace.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ services:
shm_size: 1g
ulimits:
core: -1
# Setting nofile to 4096 and hard to 1048576, as recommended by Solace documentation
# Otherwise, the container will have an error and crash with:
# ERROR POST Violation [022]:Required system resource missing, Hard resource limit nofile 1048576 is required, 6592 detected
# https://docs.solace.com/Software-Broker/System-Resource-Requirements.htm#concurrent-open-files-considerations
nofile:
soft: 2448
hard: 6592
soft: 4096
hard: 1048576
deploy:
restart_policy:
condition: on-failure
Expand Down
8 changes: 8 additions & 0 deletions .github/scripts/components-scripts/docker-compose-logs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/bash

set -e

FILE="$1"
PROJECT="${2:-$FILE}"

docker compose -f .github/infrastructure/docker-compose-${FILE}.yml -p ${PROJECT} logs
4 changes: 4 additions & 0 deletions .github/scripts/test-info.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@ const components = {
'pubsub.solace': {
conformance: true,
conformanceSetup: 'docker-compose.sh solace',
conformanceLogs: 'docker-compose-logs.sh solace',
},
'secretstores.azure.keyvault': {
certification: true,
Expand Down Expand Up @@ -824,6 +825,7 @@ const components = {
* @property {boolean?} requireTerraform If true, requires Terraform
* @property {boolean?} requireKind If true, requires KinD
* @property {string?} conformanceSetup Setup script for conformance tests
* @property {string?} conformanceLogs Logs script for conformance tests
* @property {string?} conformanceDestroy Destroy script for conformance tests
* @property {string?} certificationSetup Setup script for certification tests
* @property {string?} certificationDestroy Destroy script for certification tests
Expand All @@ -845,6 +847,7 @@ const components = {
* @property {boolean?} require-kind Requires KinD
* @property {string?} setup-script Setup script
* @property {string?} destroy-script Destroy script
* @property {string?} logs-script Logs script in case of failure
* @property {string?} nodejs-version Install the specified Node.js version if set
* @property {string?} mongodb-version Install the specified MongoDB version if set
* @property {string?} source-pkg Source package
Expand Down Expand Up @@ -915,6 +918,7 @@ function GenerateMatrix(testKind, enableCloudTests) {
'require-kind': comp.requireKind ? 'true' : undefined,
'setup-script': comp[testKind + 'Setup'] || undefined,
'destroy-script': comp[testKind + 'Destroy'] || undefined,
'logs-script': comp[testKind + 'Logs'] || undefined,
'nodejs-version': comp.nodeJsVersion || undefined,
'mongodb-version': comp.mongoDbVersion || undefined,
'source-pkg': comp.sourcePkg
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/conformance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,10 @@ jobs:
exit 1
fi

- name: Retrieve infrastructure failure logs
if: failure() && matrix.logs-script != ''
run: .github/scripts/components-scripts/${{ matrix.logs-script }}

- name: Prepare test result info
if: always()
run: |
Expand Down
Loading